Eric S. (eseale) reviewed National Geographic Photography Field Guide: Secrets to Making Great Pictures on
The primary weakness of this book is that it only briefly touches on the digital era. Most of its first half is devoted to film photography, and so of little use to many readers. Discussions of the best film to use in a given situation are moot when most of the discussed film types are no longer in production / available for purchase.
Fortunately, the majority of the book's second half is devoted to discussions of photography approaches, styles, and such. Since this section largely consists of 2-page treatments of a variety of professional photographers and their work, you can pick up a lot of good tips from it.